From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by sourceware.org (Postfix) with ESMTPS id 586B13851C09 for ; Mon, 25 May 2020 13:39:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 586B13851C09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=serhei.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=me@serhei.io Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 7491F5C00DF; Mon, 25 May 2020 09:39:56 -0400 (EDT) Received: from imap21 ([10.202.2.71]) by compute7.internal (MEProxy); Mon, 25 May 2020 09:39:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=serhei.io; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=NYx6tYxs6iKuz6ufVEf8s2GrVeGC3cj kupbh/qExZjs=; b=Dx4o45FbUENNo8iH+FzPb3/AxX1QRjblNO8wCYv2ZyXmTyT fixjhHTj+IEc8EszCUkG5wK8IVIwvXr7Lic0hNKImloUKVygrvuoPqyPpdWXBZXu tvtedaUiM0AKD8+MAu8bPkbAp3W1QN7vQZdav4vnSLaQjNtJY17X8lguHpFyc9C6 chajg5Hp+cIEP1X3eodfIhUPxjPoiHHLCVfAU9rXuR/A6YLuUd4kN1KRtyjAtB+J vtgSx2oiXAcXYEXkCxOXltntznv5BS7YjDpuxgbKu4cj+mbYzhuiBO9gDyFsyDnG hQHeROLF8QTTLgKJ3qKJYwjNIVeGLdwNfUCoDiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=NYx6tY xs6iKuz6ufVEf8s2GrVeGC3cjkupbh/qExZjs=; b=ucxIf+r3ZtwGD1p4uibT/M kJp7ludWXlad6OXpdve463VlpUVqyxFnGHGeuEhMKGTq2qFxZyqS8lg1a7EgNOui qF3p/FvCW6FTR+eT/truk5GLprnqeetafxKQn2ZGaH05pXECzpW9TmWWfOz2VUD1 rTjzNfsBEAPrR0qzde+ToSIvBZPoHQCAKYA4osPD9LlxDx9JhA/+Zv3LBdGjPo+V gbeXT4fPRPAJELypm5N1F3NviObfKsN7p5J9yIBE+hcgtvM5F4LiCISCytjop4lR AG64bShaqaPr1zFNO7dCKHqSSX8sqA9WWoCzPb9YVosN30ITVSKvcbkA7i38DneA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddvtddgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdfuvghr hhgvihcuofgrkhgrrhhovhdfuceomhgvsehsvghrhhgvihdrihhoqeenucggtffrrghtth gvrhhnpedthfeuhfffieeludeijeevueeghfehvdefhfdutdekhedthfegjeeigfduhedv feenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmvg esshgvrhhhvghirdhioh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8D9EA66007F; Mon, 25 May 2020 09:39:55 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-dev0-488-g9249dd4-fm-20200522.001-g9249dd48 Mime-Version: 1.0 Message-Id: In-Reply-To: <6D776DD5-8DD9-41C7-B166-25EDD6B81857@gmx.de> References: <6D776DD5-8DD9-41C7-B166-25EDD6B81857@gmx.de> Date: Mon, 25 May 2020 09:39:35 -0400 From: "Serhei Makarov" To: "Torsten Polle" , "Serhei Makarov" Cc: systemtap Subject: =?UTF-8?Q?Re:_PR11599:_update_STAPCONF=5FTRACEPOINT=5FHAS=5FDATA_to_work?= =?UTF-8?Q?_with_kernel_5.7.0+?= Content-Type: text/plain X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 13:40:02 -0000 Hello Torsten, Thank you very much for testing the change! I went to apply your patch this morning and saw that Frank also caught the same problem and fixed it with commit 823a77ab03c3. If that approach to fix it still generates a warning, I'll apply your patch. In answer to your question, to remove the definition of stp_tracepoints.h, the autoconf file must compile correctly on every prior kernel version where DECLARE_TRACE_NOARGS was defined. I have not verified this, so I can only be certain the autoconf check is appropriate for kernel 5.7+. For earlier versions, we continue to check for DECLARE_TRACE_NOARGS. All the best, Serhei On Sun, May 24, 2020, at 10:07 AM, Torsten Polle wrote: > Hi Serhei, > > Your patch introduces a new source for the definition of > STAPCONF_TRACEPOINT_HAS_DATA in the files generated by autoconf, which > conflicts with the original definition stp_tracepoints.h. > > The following patch remedies this situation at least in my environment. > But I wonder whether the definition in stp_tracepoints.h could be > simply removed. > > Kind Regards, > Torsten > > Attachments: > * PR11599-Fix-STAPCONF_TRACEPOINT_HAS_DATA-already-def.patch