From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48473 invoked by alias); 27 Sep 2016 08:44:26 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 48353 invoked by uid 48); 27 Sep 2016 08:44:14 -0000 From: "mcermak at redhat dot com" To: systemtap@sourceware.org Subject: [Bug runtime/10234] clean up aggregate hard-coded logic Date: Tue, 27 Sep 2016 08:44:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mcermak at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2016-q3/txt/msg00307.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D10234 --- Comment #8 from Martin Cermak --- Created attachment 9525 --> https://sourceware.org/bugzilla/attachment.cgi?id=3D9525&action=3Dedit proposed prototype patch The attached patch based on inlining the __stp_stat_add(), and adding a few integer parameters denoting relevant stat ops, seems to help GCC to effecti= vely optimize this function. Very rough testing shows about 17% shrinkage, which is roughly about the sa= me as with the patch from Comment #6 (based on preprocessing phase of the runt= ime compilation). The results were acquired using gcc-6.2.1-1.fc26.x86_64 and = -O2 for the module compilation. --=20 You are receiving this mail because: You are the assignee for the bug.