From: "fche at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/10234] clean up aggregate hard-coded logic
Date: Tue, 13 Sep 2016 18:53:00 -0000 [thread overview]
Message-ID: <bug-10234-6586-hHh2zSo47n@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-10234-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=10234
--- Comment #4 from Frank Ch. Eigler <fche at redhat dot com> ---
One could measure some of the combinations.
In particular, compare the three options
if (val > sd->max) sd->max = val;
if (sd->hist_ops & STAT_OP_MAX && val > sd->max) sd->max = val;
if (unlikely(sd->hist_ops & STAT_OP_MAX && val > sd->max)) sd->max = val;
for one or all of the aggregate variables. That's a number of combinations to
test, but maybe with some #ifdef's and some shell script stap -D'ing, one can
get the computer to explore the whole space.
(Since it's unlikely we'll have a compile-time-only method ... like your #if 0
... unless we were to go to generated-code templates kind of like map-gen* etc.
for the various cartesian-product alternatives.)
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2016-09-13 18:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-10234-6586@http.sourceware.org/bugzilla/>
2016-09-13 15:26 ` mcermak at redhat dot com
2016-09-13 18:53 ` fche at redhat dot com [this message]
2016-09-16 7:59 ` mcermak at redhat dot com
2016-09-20 14:34 ` mcermak at redhat dot com
2016-09-23 14:35 ` mcermak at redhat dot com
2016-09-27 8:44 ` mcermak at redhat dot com
2016-09-30 10:34 ` mcermak at redhat dot com
2016-10-03 9:01 ` mcermak at redhat dot com
2016-10-05 7:36 ` mcermak at redhat dot com
2016-10-06 22:05 ` mcermak at redhat dot com
2009-06-03 17:45 [Bug runtime/10234] New: " fche at redhat dot com
2009-06-03 17:49 ` [Bug runtime/10234] " fche at redhat dot com
2009-06-03 18:01 ` leitao at linux dot vnet dot ibm dot com
2009-06-03 18:18 ` jkenisto at us dot ibm dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-10234-6586-hHh2zSo47n@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).