From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14641 invoked by alias); 6 Jan 2011 20:58:48 -0000 Received: (qmail 14632 invoked by uid 22791); 6 Jan 2011 20:58:47 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO sourceware.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Jan 2011 20:58:43 +0000 From: "dsmith at redhat dot com" To: systemtap@sources.redhat.com Subject: [Bug runtime/12341] deref()/store_deref() variations between arches X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dsmith at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sources dot redhat.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Thu, 06 Jan 2011 20:58:00 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q1/txt/msg00012.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=12341 --- Comment #2 from David Smith 2011-01-06 20:58:39 UTC --- (In reply to comment #0) > For powerpc, deref() calls __stp_get_user_asm(), which is custom powerpc > assembly code (that looks almost identical to the kernel's __get_user_asm()). > store_deref() calls __stp_put_user_asm(), which is custom powerpc assembly > code. For powerpc, I've discovered some history. loc2c-runtime.h originally used the kernel's __get_user_asm() macros. This changed on 20 Mar 2006 in the following commit: To fix bug 2076 (ppc64 runtime is broken under kernel v2.6.15-RC5): which was caused by the "__get_user_asm" macro changing to taking 4 arguments (from 5). There is (hopefully) a better way to fix that problem than duplicating __get_user_asm()/__put_user_asm(). Note that we just can't go back to calling __get_user_asm(), since in current kernels __get_user_asm2() is used on powerpc to get 64-bit values. We'll need to call something a bit higher up. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.