From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18750 invoked by alias); 9 Feb 2011 17:19:17 -0000 Received: (qmail 18740 invoked by uid 22791); 9 Feb 2011 17:19:16 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO sourceware.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Feb 2011 17:19:09 +0000 From: "dsmith at redhat dot com" To: systemtap@sources.redhat.com Subject: [Bug tapsets/12471] Support wait4 *status printing X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: tapsets X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dsmith at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sources dot redhat.com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Wed, 09 Feb 2011 17:19:00 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q1/txt/msg00226.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=12471 David Smith changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dsmith at redhat dot com --- Comment #1 from David Smith 2011-02-09 17:19:01 UTC --- (In reply to comment #0) > Created attachment 5232 [details] > wait4 *status printing > > probe syscall.wait4.return { printf ("%s(%s)=%s\n", name, argstr, retstr) } > > then prints nice: > wait4(-1, N/A, WNOHANG|__WCLONE, 0x0)=-10 (ECHILD) > wait4(-1, WSTOPSIG=SIGTRAP, WNOHANG, 0x0)=9319 > > The problem is we need argstr from the .return function. > Could we start providing argstr in all the syscall.return tapset hook? > > This patch is on top of Bug 12470. > > I do not understand where everywhere the code should be, it works here but > there is a massive duplication of all the wait* syscall hooks. I'm not too fond of this change: it changes the meaning of 'argstr' and we don't really have access to entry arguments in return probes (it works, because we add a hidden entry probe to cache the values). Perhaps adding a new variable called 'statusstr' or 'status_str' that just gets the value of _wait_status_str() is a better idea. We could also provide the user with WIFEXITED/WEXITSTATUS/etc. functions if anyone thinks that would be a good idea. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.