[Bug translator/12591] New: Using a compile server breaks signaled cleanup

[Bug translator/12591] New: Using a compile server breaks signaled cleanup

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12591

           Summary: Using a compile server breaks signaled cleanup
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap@sourceware.org
        ReportedBy: jistone@redhat.com


When --use-server is specified, stap no longer responds cleanly to signals --
neither terminal CTRL-C nor "kill $STAPPID" are handled gracefully.

  stap --use-server=vm-f14-64:3372 -ve 'probe begin, end { println(pp()) }'

If signaled while the server is busy, then stap just quits silently (not sure
if the server finishes though).  If allowed to start pass-5, stap still dumps
out, but the module cleanup depends on the signal source.  CTRL-C will still
reach stapio, so the module will unload, but "kill $STAPPID" will leave the
module running.

In either case, the /tmp/stapXXXXXX is not removed, and stap's $? is 130.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug translator/12591] Using a compile server breaks signaled cleanup

[jistone at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=12591

--- Comment #1 from Josh Stone <jistone at redhat dot com> 2011-03-17 18:39:13 UTC ---
Added commit b7a0f5a:

    PR12591: Setup the signal handler earlier

    We were calling setup_signals() in passes_0_4(), but --use-server
    diverts that execution path, so signaled cleanup wasn't working in that
    case at all.  It's also possible with multiple --remotes that
    passes_0_4() will be called multiple times, though that shouldn't really
    hurt signal handling.  This patch moves setup_signals() to main(), so it
    is called once early on.

    * main.cxx (passes_0_4): Don't call setup_signals() here.
      (main): Call setup_signals() here instead.

Now the signaled cleanup happens correctly in every case that I see.  However,
if interrupted while the server is busy, we end up waiting for that completion
before actually exiting.  It would be nice if the remote server were also
signaled so we could have a more timely exit.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.