From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15921 invoked by alias); 17 Mar 2011 18:39:25 -0000 Received: (qmail 15914 invoked by uid 22791); 17 Mar 2011 18:39:25 -0000 X-SWARE-Spam-Status: No, hits=-50.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO sourceware.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Mar 2011 18:39:22 +0000 From: "jistone at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/12591] Using a compile server breaks signaled cleanup X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jistone at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Thu, 17 Mar 2011 18:39:00 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q1/txt/msg00485.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=12591 --- Comment #1 from Josh Stone 2011-03-17 18:39:13 UTC --- Added commit b7a0f5a: PR12591: Setup the signal handler earlier We were calling setup_signals() in passes_0_4(), but --use-server diverts that execution path, so signaled cleanup wasn't working in that case at all. It's also possible with multiple --remotes that passes_0_4() will be called multiple times, though that shouldn't really hurt signal handling. This patch moves setup_signals() to main(), so it is called once early on. * main.cxx (passes_0_4): Don't call setup_signals() here. (main): Call setup_signals() here instead. Now the signaled cleanup happens correctly in every case that I see. However, if interrupted while the server is busy, we end up waiting for that completion before actually exiting. It would be nice if the remote server were also signaled so we could have a more timely exit. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.