From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-18114-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 5921 invoked by alias); 20 Jul 2011 23:14:39 -0000
Received: (qmail 5914 invoked by uid 22791); 20 Jul 2011 23:14:38 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO sourceware.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jul 2011 23:14:25 +0000
From: "jistone at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/13009] Allow @defined($foo) in probe predicates
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: translator
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: jistone at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-13009-6586-xIwze1jwck@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-13009-6586@http.sourceware.org/bugzilla/>
References: <bug-13009-6586@http.sourceware.org/bugzilla/>
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Wed, 20 Jul 2011 23:14:00 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2011-q3/txt/msg00068.txt.bz2

http://sourceware.org/bugzilla/show_bug.cgi?id=13009

--- Comment #2 from Josh Stone <jistone at redhat dot com> 2011-07-20 23:13:42 UTC ---
(In reply to comment #1)
> "But this gives "semantic error: unexpected @defined". "
> 
> That's odd - the code should accept pretty general expressions.

That's coming from typeresolution_info::visit_defined_op, as it's not expecting
@defined expressions to survive this far.  We may just need to tweak all the
var_expanding_visitor invocations to visit the predicate too.

> "and probes with empty bodies are discarded entirely."
> 
> That's bug #11353.

Ah, yes, thanks for jogging my memory.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.