From: "mjw at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug kprobes/13108] kprobing some paravirt stuff seems unsafe
Date: Mon, 05 Sep 2011 22:08:00 -0000 [thread overview]
Message-ID: <bug-13108-6586-80ZLUcFJ9B@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-13108-6586@http.sourceware.org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=13108
Mark Wielaard <mjw at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Mark Wielaard <mjw at redhat dot com> 2011-09-05 22:07:56 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> > The patch in comment #1 doesn't seem to prevent setting a probe on
> > kernel.function("clts"), so it is wrong, haven't figured out why yet though.
>
> Ugh -- I think you've uncovered another bug, that blfile probably shouldn't be
> ^-anchored at the start.
Wow, you are right! After some experimentation it seems only include/asm/*.h
files that get selected by "full path". So I fixed it with:
commit 44a7e76ab8cd9b9942b8d8a72d065269cd637c4a
Author: Mark Wielaard <mjw@redhat.com>
Date: Mon Sep 5 23:37:11 2011 +0200
PR13112 (and PR13108) blacklist probing function from include/asm .h files.
dwflpp.cxx (build_blacklist): all include/asm .h blfile patterns might
need "full path" so prefix those with '.*'
Add new XFAIL semok.exp inb_blacklisted.stp testcase.
Plus a patch to explicitly list the paravirt ops functions with:
commit 1b43894364dec075d13636b3c78c786da73fc8ad
Author: Mark Wielaard <mjw@redhat.com>
Date: Mon Sep 5 23:44:53 2011 +0200
PR13108 blacklist probing paravirt ops from paravirt.c or paravirt.h.
See also the follow up commit 4a507d for PR13112.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
prev parent reply other threads:[~2011-09-05 22:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 20:08 [Bug kprobes/13108] New: " mjw at redhat dot com
2011-08-18 20:15 ` [Bug kprobes/13108] " mjw at redhat dot com
2011-08-18 21:32 ` jistone at redhat dot com
2011-09-05 22:08 ` mjw at redhat dot com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-13108-6586-80ZLUcFJ9B@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).