From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29748 invoked by alias); 18 Aug 2011 21:32:12 -0000 Received: (qmail 29740 invoked by uid 22791); 18 Aug 2011 21:32:12 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO sourceware.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Aug 2011 21:31:55 +0000 From: "jistone at redhat dot com" To: systemtap@sourceware.org Subject: [Bug kprobes/13108] kprobing some paravirt stuff seems unsafe Date: Thu, 18 Aug 2011 21:32:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: kprobes X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jistone at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00180.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=13108 Josh Stone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jistone at redhat dot com --- Comment #2 from Josh Stone 2011-08-18 21:31:50 UTC --- (In reply to comment #1) > The patch in comment #1 doesn't seem to prevent setting a probe on > kernel.function("clts"), so it is wrong, haven't figured out why yet though. Ugh -- I think you've uncovered another bug, that blfile probably shouldn't be ^-anchored at the start. I get: > $ stap -l 'kernel.function("*@paravirt*.c")' | wc -l > 0 > $ stap -l 'kernel.function("*@paravirt*.h")' | wc -l > 93 > $ stap -l 'kernel.function("clts")' > kernel.function("clts@/usr/src/debug/kernel-2.6.39.fc15/linux-2.6.39.x86_64/arch/x86/include/asm/paravirt.h:47") It looks like all #include files are showing a full path, thus we shouldn't expect to match the leading portions at all. Either those specific asm paths need a ".*" in front, or we can remove the "^" from blfile altogether. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.