[Bug testsuite/13133] New: sdt_misc.exp's wildcard criterion should be changed

[Bug testsuite/13133] New: sdt_misc.exp's wildcard criterion should be changed

[phan at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13133

             Bug #: 13133
           Summary: sdt_misc.exp's wildcard criterion should be changed
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
        AssignedTo: systemtap@sourceware.org
        ReportedBy: phan@redhat.com
    Classification: Unclassified


Created attachment 5911
  --> http://sourceware.org/bugzilla/attachment.cgi?id=5911
the patch

On i386 and x86_64 system, sdt_misc.exp fails with those messages:

i386:
FAIL: sdt_misc wildcard (40) V1_uprobe
FAIL: sdt_misc wildcard (40) V2_kprobe
FAIL: sdt_misc wildcard (40) V2_uprobe
FAIL: sdt_misc wildcard (40) V3_uprobe

x86_64:
FAIL: sdt_misc wildcard (48) V1_uprobe
FAIL: sdt_misc wildcard (48) V2_kprobe
FAIL: sdt_misc wildcard (48) V2_uprobe
FAIL: sdt_misc wildcard (48) V3_uprobe

I believe this because three variables, arr_struct, primary_colors_var,
incomplete_struct_type, has been changed to conditional defined in
systemtap.base/sdt_types.c:

 92 # if !defined(__cplusplus) || \
 93         ((__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5)) &&
__GXX_EXPERIMENTAL_CXX0X__)
 94   struct {
 95     int int_var;
 96   } arr_struct [2] = {{1},{2}};
 97
 98   enum  {
 99     red = 0,
100     green = 1,
101     blue = 2
102   } primary_colors_var = green;
103
104   struct opaque_struct *incomplete_struct_type = 0;
105 # endi

The criterion should be changed to something like this:

diff --git a/testsuite/systemtap.base/sdt_misc.exp
b/testsuite/systemtap.base/sdt_misc.exp
index e5b2c80..0ffbfa0 100644
--- a/testsuite/systemtap.base/sdt_misc.exp
+++ b/testsuite/systemtap.base/sdt_misc.exp
@@ -389,7 +389,7 @@ expect {

 catch {close}; catch {wait}

-if { $ok == 51 || ($ok == 43 && [regexp "^(i.86)$" $::tcl_platform(machine)])}
{
+if { $ok == 51 || $ok == 48 || (($ok == 43 || $ok == 40 ) && [regexp
"^(i.86)$" $::tcl_platform(machine)])} {
     pass "$test wildcard $pbtype_mssg"
 } else {
     fail "$test wildcard ($ok) $pbtype_mssg"

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug testsuite/13133] sdt_misc.exp's wildcard criterion should be changed

[mjw at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13133

Mark Wielaard <mjw at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |mjw at redhat dot com
         Resolution|                            |FIXED

--- Comment #1 from Mark Wielaard <mjw at redhat dot com> 2011-09-07 10:32:16 UTC ---
Agreed. Tested against gcc 4.5.1 and gcc 4.4.5 on x86_64. Applied.

commit c51f7d9a6d14226ae76e071fddf6093c06602632
Author: Han Pingtian <phan@redhat.com>
Date:   Wed Aug 17 17:23:58 2011 +0800

    change probe wildcard matching criterion in sdt_misc.exp

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.