public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug runtime/13146] New: memory allocation can sleep
@ 2011-09-01 14:35 dsmith at redhat dot com
  2011-09-01 14:51 ` [Bug runtime/13146] " dsmith at redhat dot com
  2011-09-01 14:52 ` dsmith at redhat dot com
  0 siblings, 2 replies; 3+ messages in thread
From: dsmith at redhat dot com @ 2011-09-01 14:35 UTC (permalink / raw)
  To: systemtap

http://sourceware.org/bugzilla/show_bug.cgi?id=13146

             Bug #: 13146
           Summary: memory allocation can sleep
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap@sourceware.org
        ReportedBy: dsmith@redhat.com
    Classification: Unclassified


When the systemtap runtime allocates memory, it uses GFP_KERNEL (possibly with
other flags).  GFP_KERNEL includes __GFP_WAIT, which means that the memory
allocation could possibly sleep.

Systemtap probe handlers should not sleep.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug runtime/13146] memory allocation can sleep
  2011-09-01 14:35 [Bug runtime/13146] New: memory allocation can sleep dsmith at redhat dot com
@ 2011-09-01 14:51 ` dsmith at redhat dot com
  2011-09-01 14:52 ` dsmith at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: dsmith at redhat dot com @ 2011-09-01 14:51 UTC (permalink / raw)
  To: systemtap

http://sourceware.org/bugzilla/show_bug.cgi?id=13146

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from David Smith <dsmith at redhat dot com> 2011-09-01 14:50:44 UTC ---
Fixed in commit 8e794e9 (which also fixes a couple of places to handle memory
allocation failures better).

Regression tested on:

RHEL4:   2.6.9-100.ELsmp (i686)
RHEL5:   2.6.18-274.el5debug (x86_64)
RHEL6:   2.6.32-192.el6.x86_64.debug (x86_64)
f15:     2.6.40.3-0.fc15.i686.debug (i686)
rawhide: 3.0.1-6.fc17.x86_64 (x86_64)

Note that this came up while working on bug #10994.  During some utrace probe
handlers, memory allocation is done (typically to allocate space for a
pathname).  That is fine, since utrace probe handlers are run in a sleepable
context.

However, the new utrace-free task_finder will be implemented via tracepoints,
and tracepoint probe handers are not run in a sleepable context.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug runtime/13146] memory allocation can sleep
  2011-09-01 14:35 [Bug runtime/13146] New: memory allocation can sleep dsmith at redhat dot com
  2011-09-01 14:51 ` [Bug runtime/13146] " dsmith at redhat dot com
@ 2011-09-01 14:52 ` dsmith at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: dsmith at redhat dot com @ 2011-09-01 14:52 UTC (permalink / raw)
  To: systemtap

http://sourceware.org/bugzilla/show_bug.cgi?id=13146

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10994

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-09-01 14:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-01 14:35 [Bug runtime/13146] New: memory allocation can sleep dsmith at redhat dot com
2011-09-01 14:51 ` [Bug runtime/13146] " dsmith at redhat dot com
2011-09-01 14:52 ` dsmith at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).