public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug translator/13156] New: improve hash_XXX.log
@ 2011-09-06 18:02 fche at redhat dot com
  2011-09-14 13:21 ` [Bug translator/13156] " cmeek at redhat dot com
  0 siblings, 1 reply; 2+ messages in thread
From: fche at redhat dot com @ 2011-09-06 18:02 UTC (permalink / raw)
  To: systemtap

http://sourceware.org/bugzilla/show_bug.cgi?id=13156

             Bug #: 13156
           Summary: improve hash_XXX.log
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap@sourceware.org
        ReportedBy: fche@redhat.com
    Classification: Unclassified


We generate a FOO_hash.log text file in the module cache to sort of document
how the hash value came to be.  (PR9931).  This has not quite lived up to its
potential though as the hash.log file does not name the values.  For example,
some random script's log contains:

[Wed Aug 31 10:28:36 2011] script_hash:
2.6.38.8-35.fc15.x86_64
/lib/modules/2.6.38.8-35.fc15.x86_64/build
4096
1312128479
x86_64
/lib/modules/2.6.38.8-35.fc15.x86_64/build/.config
114130
1309961071

where each number / string is the data that got munged into the overall hash,
but lacks a name to document it.  It would be nice if the hash.cxx parm_stream
bits were extended so that some metadata were made available.  One way would
be to extend all the hash::add* member functions to take an extra description
string, and paste that only into the parm_stream.  Another way would be to 
add a single function hash::describe(const string&) that adds the given
string to the parm_stream only (and not to the md4 state), to be used thusly.
e.g. get_base_hash():

+ h.describe("kernel relase:");
  h.add(s.kernel_release);
+ h.describe("kernel build tree:");
  h.add_path(s.kernel_build_tree);
+ h.describe("arch:");
  h.add(s.architecture);

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug translator/13156] improve hash_XXX.log
  2011-09-06 18:02 [Bug translator/13156] New: improve hash_XXX.log fche at redhat dot com
@ 2011-09-14 13:21 ` cmeek at redhat dot com
  0 siblings, 0 replies; 2+ messages in thread
From: cmeek at redhat dot com @ 2011-09-14 13:21 UTC (permalink / raw)
  To: systemtap

http://sourceware.org/bugzilla/show_bug.cgi?id=13156

Chris Meek <cmeek at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cmeek at redhat dot com
         AssignedTo|systemtap at sourceware dot |cmeek at redhat dot com
                   |org                         |

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-09-14 13:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-06 18:02 [Bug translator/13156] New: improve hash_XXX.log fche at redhat dot com
2011-09-14 13:21 ` [Bug translator/13156] " cmeek at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).