From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1859 invoked by alias); 6 Sep 2011 18:02:48 -0000 Received: (qmail 1850 invoked by uid 22791); 6 Sep 2011 18:02:47 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO sourceware.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Sep 2011 18:02:29 +0000 From: "fche at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/13156] New: improve hash_XXX.log Date: Tue, 06 Sep 2011 18:02:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: fche at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00285.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=13156 Bug #: 13156 Summary: improve hash_XXX.log Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: translator AssignedTo: systemtap@sourceware.org ReportedBy: fche@redhat.com Classification: Unclassified We generate a FOO_hash.log text file in the module cache to sort of document how the hash value came to be. (PR9931). This has not quite lived up to its potential though as the hash.log file does not name the values. For example, some random script's log contains: [Wed Aug 31 10:28:36 2011] script_hash: 2.6.38.8-35.fc15.x86_64 /lib/modules/2.6.38.8-35.fc15.x86_64/build 4096 1312128479 x86_64 /lib/modules/2.6.38.8-35.fc15.x86_64/build/.config 114130 1309961071 where each number / string is the data that got munged into the overall hash, but lacks a name to document it. It would be nice if the hash.cxx parm_stream bits were extended so that some metadata were made available. One way would be to extend all the hash::add* member functions to take an extra description string, and paste that only into the parm_stream. Another way would be to add a single function hash::describe(const string&) that adds the given string to the parm_stream only (and not to the md4 state), to be used thusly. e.g. get_base_hash(): + h.describe("kernel relase:"); h.add(s.kernel_release); + h.describe("kernel build tree:"); h.add_path(s.kernel_build_tree); + h.describe("arch:"); h.add(s.architecture); -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.