public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "jistone at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/13186] systemtap does not correctly point out offending structure when accidentally dereferencing a structure as a string
Date: Tue, 13 Sep 2011 19:53:00 -0000	[thread overview]
Message-ID: <bug-13186-6586-xxBC6wGT2S@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-13186-6586@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=13186

--- Comment #2 from Josh Stone <jistone at redhat dot com> 2011-09-13 19:53:16 UTC ---
(In reply to comment #0)
> semantic error: 'struct qstr' is being accessed instead of a member: identifier
> '$kobj' at /tmp/sysfs.stp:14:53
>         source:                 printf("%s :
> %s\n",thread_indent(1),kernel_string($kobj->dentry->d_name))
>                                      ^
> 
> Here d_name is a structure of type qstr; which is the offending dereference
> however the translator points to $kobj instead of d_name.

The message is generated by dwflpp::translate_final_fetch_or_store, using the
token of the overall expression (e->tok).  It should be possible to use the
token of the last dereferencing e->component instead, falling back to e->tok
only if there are no components.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

      parent reply	other threads:[~2011-09-13 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-13 19:43 [Bug translator/13186] New: " anish at chelsio dot com
2011-09-13 19:50 ` [Bug translator/13186] " anish at chelsio dot com
2011-09-13 19:53 ` jistone at redhat dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-13186-6586-xxBC6wGT2S@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).