public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/13452] tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_eventfd2()
Date: Wed, 30 Nov 2011 16:54:00 -0000	[thread overview]
Message-ID: <bug-13452-6586-STwqnmU7GL@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-13452-6586@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=13452

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com
         Depends on|                            |11424

--- Comment #1 from David Smith <dsmith at redhat dot com> 2011-11-30 16:53:02 UTC ---
Here's a bit more from tapset/syscalls.stp:

----
# eventfd _____________________________________________________                 
# long sys_eventfd(unsigned int count)                                          
# SYSCALL_DEFINE2(eventfd2, unsigned int, count, int, flags)                    
probe syscall.eventfd = kernel.function("sys_eventfd2").call !,                 
                        kernel.function("sys_eventfd").call ?                   
----

The reason why it is done this way is that in the kernel sys_eventfd is just a
wrapper around sys_eventfd2.  This way we ignore the sys_eventfd call, and only
catch the sys_eventfd2 call on kernels with sys_eventfd2.

Unfortunately, as bug #11424 notes, '!' (optional and sufficient) doesn't work
for kprobe.function probes.  So, the above logic will be difficult to duplicate
in tapset/nd_syscalls.stp.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

  reply	other threads:[~2011-11-30 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 19:21 [Bug tapsets/13452] New: " mjw at redhat dot com
2011-11-30 16:54 ` dsmith at redhat dot com [this message]
2012-07-18 18:35 ` [Bug tapsets/13452] " dsmith at redhat dot com
2012-07-20 19:48 ` dsmith at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-13452-6586-STwqnmU7GL@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).