* [Bug tapsets/13452] New: tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_eventfd2()
@ 2011-11-29 19:21 mjw at redhat dot com
2011-11-30 16:54 ` [Bug tapsets/13452] " dsmith at redhat dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: mjw at redhat dot com @ 2011-11-29 19:21 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13452
Bug #: 13452
Summary: tapset/nd_syscalls.stp:# FIXME: doesn't handle
sys_eventfd2()
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: tapsets
AssignedTo: systemtap@sourceware.org
ReportedBy: mjw@redhat.com
Classification: Unclassified
The corresponding tapset/syscalls.stp has:
# SYSCALL_DEFINE2(eventfd2, unsigned int, count, int, flags)
probe syscall.eventfd = kernel.function("sys_eventfd2").call !,
kernel.function("sys_eventfd").call ?
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug tapsets/13452] tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_eventfd2()
2011-11-29 19:21 [Bug tapsets/13452] New: tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_eventfd2() mjw at redhat dot com
@ 2011-11-30 16:54 ` dsmith at redhat dot com
2012-07-18 18:35 ` dsmith at redhat dot com
2012-07-20 19:48 ` dsmith at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dsmith at redhat dot com @ 2011-11-30 16:54 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13452
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dsmith at redhat dot com
Depends on| |11424
--- Comment #1 from David Smith <dsmith at redhat dot com> 2011-11-30 16:53:02 UTC ---
Here's a bit more from tapset/syscalls.stp:
----
# eventfd _____________________________________________________
# long sys_eventfd(unsigned int count)
# SYSCALL_DEFINE2(eventfd2, unsigned int, count, int, flags)
probe syscall.eventfd = kernel.function("sys_eventfd2").call !,
kernel.function("sys_eventfd").call ?
----
The reason why it is done this way is that in the kernel sys_eventfd is just a
wrapper around sys_eventfd2. This way we ignore the sys_eventfd call, and only
catch the sys_eventfd2 call on kernels with sys_eventfd2.
Unfortunately, as bug #11424 notes, '!' (optional and sufficient) doesn't work
for kprobe.function probes. So, the above logic will be difficult to duplicate
in tapset/nd_syscalls.stp.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug tapsets/13452] tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_eventfd2()
2011-11-29 19:21 [Bug tapsets/13452] New: tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_eventfd2() mjw at redhat dot com
2011-11-30 16:54 ` [Bug tapsets/13452] " dsmith at redhat dot com
@ 2012-07-18 18:35 ` dsmith at redhat dot com
2012-07-20 19:48 ` dsmith at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dsmith at redhat dot com @ 2012-07-18 18:35 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13452
Bug 13452 depends on bug 11424, which changed state.
Bug 11424 Summary: dwarfless kprobe.* probes don't validate at translate time
http://sourceware.org/bugzilla/show_bug.cgi?id=11424
What |Old Value |New Value
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug tapsets/13452] tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_eventfd2()
2011-11-29 19:21 [Bug tapsets/13452] New: tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_eventfd2() mjw at redhat dot com
2011-11-30 16:54 ` [Bug tapsets/13452] " dsmith at redhat dot com
2012-07-18 18:35 ` dsmith at redhat dot com
@ 2012-07-20 19:48 ` dsmith at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dsmith at redhat dot com @ 2012-07-20 19:48 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13452
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from David Smith <dsmith at redhat dot com> 2012-07-20 19:47:55 UTC ---
Now that bug #11424 and bug #14378 are fixed, this bug can be addressed.
Fixed in commit f6f8f0e.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-20 19:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-29 19:21 [Bug tapsets/13452] New: tapset/nd_syscalls.stp:# FIXME: doesn't handle sys_eventfd2() mjw at redhat dot com
2011-11-30 16:54 ` [Bug tapsets/13452] " dsmith at redhat dot com
2012-07-18 18:35 ` dsmith at redhat dot com
2012-07-20 19:48 ` dsmith at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).