From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-18777-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 12460 invoked by alias); 7 Dec 2011 15:50:46 -0000
Received: (qmail 12447 invoked by uid 22791); 7 Dec 2011 15:50:45 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO sourceware.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Dec 2011 15:50:33 +0000
From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/13478] ARM tapset/signal.stp signal.handle tries to use non-existing variable $signr
Date: Wed, 07 Dec 2011 15:55:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: tapsets
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dsmith at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: CC
Message-ID: <bug-13478-6586-F1oiSOl2Pl@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-13478-6586@http.sourceware.org/bugzilla/>
References: <bug-13478-6586@http.sourceware.org/bugzilla/>
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2011-q4/txt/msg00310.txt.bz2

http://sourceware.org/bugzilla/show_bug.cgi?id=13478

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com

--- Comment #1 from David Smith <dsmith at redhat dot com> 2011-12-07 15:49:57 UTC ---
Hmm, this one is quite strange.

The following code should handle that parameter being named '$sig' or '$signr':

    if (@defined($sig)) {
        sig = $sig
        sig_name = _signal_name($sig)
    }
    else {
        sig = $signr
        sig_name = _signal_name($signr)
    }

Since stap complains about not finding $signr, that means it couldn't find $sig
either.

But, one of the listed alternatives in the following error message *is* $sig:

  semantic error: unable to find local 'signr' near pc 0xc0059a54  in 
  handle_signal arch/arm/kernel/signal.c ( (alternatives: $regs $oldset $info
$ka
  $sig): identifier '$signr' at
  /root/install/share/systemtap/tapset/signal.stp:606:15

I don't have access to an arm system so I can't really look at this.  Could you
run the following commands and attach the output?

# stap -L 'kernel.function("handle_signal").*'
# stap -vp4 -e 'probe kernel.function("handle_signal") { print($sig) }'

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.