From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32682 invoked by alias); 27 Sep 2012 16:53:03 -0000 Received: (qmail 32632 invoked by uid 48); 27 Sep 2012 16:52:43 -0000 From: "jistone at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/13486] pass-4 error (frame_base undeclared), inlined function argument Date: Thu, 27 Sep 2012 16:53:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jistone at redhat dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status Resolution Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2012-q3/txt/msg00346.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=13486 Josh Stone changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Josh Stone 2012-09-27 16:52:41 UTC --- (In reply to comment #3) > I think your patch handles this correctly. But you could consider moving the > check up into the for (l = loc; l != NULL; l = l->next) loop just above it that > checks the types. You can probably just check whether to output the frame_base > at the same time instead of looping through the location chain twice. Although > the chains aren't very deep, so it probably doesn't matter. Thanks for checking. I did consider moving it into the loop you mention, but decided not to for two reasons. First, I didn't want to perturb the relative order of the addr and frame_base declarations. Second, we only want a single frame_base declaration, even if multiple parts of the chain use it, so if we can't break the loop, then another tracking variable is needed. It seems simpler to add a new loop iteration just for the frame_base. Pushed as commit b0b86028. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.