From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-18863-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 16602 invoked by alias); 21 Dec 2011 17:52:47 -0000
Received: (qmail 16593 invoked by uid 22791); 21 Dec 2011 17:52:45 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO sourceware.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Dec 2011 17:52:33 +0000
From: "fche at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/13536] New: staprun -u race condition
Date: Wed, 21 Dec 2011 18:41:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: runtime
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: fche at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-13536-6586@http.sourceware.org/bugzilla/>
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2011-q4/txt/msg00396.txt.bz2

http://sourceware.org/bugzilla/show_bug.cgi?id=13536

             Bug #: 13536
           Summary: staprun -u race condition
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap@sourceware.org
        ReportedBy: fche@redhat.com
    Classification: Unclassified


When staprun -u/PATH is used, staprun.c:enable_uprobes() first checks
if uprobes is already in the kernel (via a hacky grep on /proc/kallsyms;
see commit 14fe042), and if that fails, it tries to insert_module the
given bad boy.  This is racy, and can result in errors such as

Error inserting module '/tmp/staphDa9p3/uprobes/uprobes.ko': File exists
WARNING: /notnfs/INST/bin/staprun exited with status: 1
Pass 5: run failed.  Try again with another '--vp 00001' option.

It's better to try and fail, than to race.

Since bug #5163, $prefix/share/systemtap/runtime/uprobes/* is never
built, so actually staprun -u (without the /path) will not generally
work.  So testsuite/.../buildid.exp needs to be updated not to muck
with -u.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.