From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23117 invoked by alias); 21 Dec 2011 19:41:58 -0000 Received: (qmail 23107 invoked by uid 22791); 21 Dec 2011 19:41:57 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO sourceware.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Dec 2011 19:41:45 +0000 From: "fche at redhat dot com" To: systemtap@sourceware.org Subject: [Bug runtime/13537] New: standardize error code handling Date: Wed, 21 Dec 2011 21:22:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: runtime X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: fche at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q4/txt/msg00398.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=13537 Bug #: 13537 Summary: standardize error code handling Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: runtime AssignedTo: systemtap@sourceware.org ReportedBy: fche@redhat.com Classification: Unclassified staprun and friends have a lot of functions that return 0 for ok and -1 (and sometimes a few other codes) for errors. This loses errno values, and doesn't let callers discriminate between problems properly. These should be standardized to return 0 for ok and -errno, basically as per the kernel. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.