[Bug testsuite/13977] rlimit tests fail as-root portions

["dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>]

http://sourceware.org/bugzilla/show_bug.cgi?id=13977

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
                 CC|                            |dsmith at redhat dot com

--- Comment #3 from David Smith <dsmith at redhat dot com> ---
When fixing some tcl errors I saw in the testsuite, I made some changes to this
test case in the following commit:

====
commit 2b70fd7894ed74c39e69d7d3a73f25984107f6f2
Author: David Smith <dsmith@redhat.com>
Date:   Tue Jun 18 14:18:47 2013 -0500

    Fix tcl and logic errors in rlimit.exp.

    * testsuite/systemtap.base/rlimit.exp: To make sure "sudo stap" works
      correctly, use the full path.
    * testsuite/lib/systemtap.exp (as_non_root): If we're running as root, use
      user "nobody" to run commands.
====

Then Josh pointed out that my 'as_non_root' fix wasn't quite correct, so I made
another change:

====
commit edb7542edea73adeb3e15e8a36af18acff4f517a
Author: David Smith <dsmith@redhat.com>
Date:   Tue Jun 18 15:46:48 2013 -0500

    Another 'as_non_root' improvement.
====

I believe those commits should fix all the problems with rlimit.exp.

Josh's original problem was that it was picking the wrong stap. The change to
rlimit.exp to use the full path of the test executable should fix that problem.

I'm not 100% sure, but I'll bet Mark's problem of those two tests failing were
because of the 2nd fix above. If you were logged in as root, 'as_non_root'
still ran the command as root. Now, if you are logged in as root, 'as_non_root'
runs the command as the user 'nobody'.

Josh and Mark, could you test and see if the above commits fix things for you?

On rawhide, this test now passes for me when run by root, run by my login, or
run with sudo.

-- 
You are receiving this mail because:
You are the assignee for the bug.