[Bug runtime/14224] New: only the 1st of multiple identical perf probes get hit

[Bug runtime/14224] New: only the 1st of multiple identical perf probes get hit

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14224

             Bug #: 14224
           Summary: only the 1st of multiple identical perf probes get hit
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap@sourceware.org
        ReportedBy: dsmith@redhat.com
    Classification: Unclassified


Created attachment 6446
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6446
test script

On rawhide (3.5.0-0.rc1.git0.1.fc18.x86_64), if you have multiple perf probes
at the same location, only the 1st probe gets hits.

====
# sudo /usr/local/bin/stap -v ../perf.stp
Pass 1: parsed user script and 85 library script(s) using
202032virt/23972res/2800shr/21672data kb, in 140usr/40sys/183real ms.
Pass 2: analyzed script: 3 probe(s), 1 function(s), 0 embed(s), 1 global(s)
using 202428virt/24764res/3080shr/22068data kb, in 10usr/0sys/6real ms.
Pass 3: translated to C into
"/tmp/stapdtN1oj/stap_ff1d3c04239a943050737602272d6026_1229_src.c" using
202552virt/24864res/3164shr/22192data kb, in 0usr/0sys/1real ms.
Pass 4: compiled C into "stap_ff1d3c04239a943050737602272d6026_1229.ko" in
2840usr/600sys/3429real ms.
Pass 5: starting run.
0
done
Pass 5: run completed in 20usr/30sys/10335real ms.
====

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/14224] only the 1st of multiple identical perf probes get hit

[dsmith at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14224

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from David Smith <dsmith at redhat dot com> 2012-06-12 20:23:57 UTC ---
Fixed in commit 369bc6e.

The original generated code always did a 'break' after registering the first
perf probe, so following ones never got registered.

====
  for (i=0; i<2; i++) {
    struct stap_perf_probe* stp = & stap_perf_probes [i];
    rc = _stp_perf_init(stp);
    if (rc) {
      probe_point = stp->probe->pp;
      for (j=0; j<i; j++) {
        _stp_perf_del(& stap_perf_probes [j]);
      }
    }
    break;
  }
====

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.