From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/14325] for arm/s390x, the nd_syscall tapsets need improvement
Date: Thu, 05 Jul 2012 13:58:00 -0000 [thread overview]
Message-ID: <bug-14325-6586-v5Ky9uaLGz@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-14325-6586@http.sourceware.org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=14325
--- Comment #1 from David Smith <dsmith at redhat dot com> 2012-07-05 13:57:41 UTC ---
(In reply to comment #0)
> Possible solutions include:
>
> - Have the *_arg() functions return a dummy value when asked for an argument it
> can't handle.
>
> - Have each architecture provide a function, something like syscall_max_args(),
> that would provide the maximum argument that this architecture supports. This
> function could be tested in each probe alias, like this:
>
> argstr = sprintf("%d %d %d %d %d", int_arg(1), int_arg(2), int_arg(3),
> int_arg(4), (syscall_max_args() >= 5 ? int_arg(5) : -1))
>
> - Continue like commit 65ddca0 and just do architecture checks everywhere
> needed.
Another solution would be to define variants of the *_arg() funtions that take
a default value (to be used when the argument isn't available). It could look
something like this (where '0' is the default value for arg 4 and -1 is the
default value for arg 5):
argstr = sprintf("%d %d %d %d %d", int_arg(1), int_arg(2), int_arg(3),
int_arg_default(4, 0), int_arg(5, -1))
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
next prev parent reply other threads:[~2012-07-05 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 21:00 [Bug tapsets/14325] New: " dsmith at redhat dot com
2012-07-05 13:58 ` dsmith at redhat dot com [this message]
2013-11-08 17:04 ` [Bug tapsets/14325] for arm, " dsmith at redhat dot com
2015-04-10 16:09 ` dsmith at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-14325-6586-v5Ky9uaLGz@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).