From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29657 invoked by alias); 5 Jul 2012 13:58:01 -0000 Received: (qmail 29630 invoked by uid 22791); 5 Jul 2012 13:57:58 -0000 X-SWARE-Spam-Status: No, hits=-3.7 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from localhost (HELO sourceware.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Jul 2012 13:57:42 +0000 From: "dsmith at redhat dot com" To: systemtap@sourceware.org Subject: [Bug tapsets/14325] for arm/s390x, the nd_syscall tapsets need improvement Date: Thu, 05 Jul 2012 13:58:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: tapsets X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dsmith at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2012-q3/txt/msg00008.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=14325 --- Comment #1 from David Smith 2012-07-05 13:57:41 UTC --- (In reply to comment #0) > Possible solutions include: > > - Have the *_arg() functions return a dummy value when asked for an argument it > can't handle. > > - Have each architecture provide a function, something like syscall_max_args(), > that would provide the maximum argument that this architecture supports. This > function could be tested in each probe alias, like this: > > argstr = sprintf("%d %d %d %d %d", int_arg(1), int_arg(2), int_arg(3), > int_arg(4), (syscall_max_args() >= 5 ? int_arg(5) : -1)) > > - Continue like commit 65ddca0 and just do architecture checks everywhere > needed. Another solution would be to define variants of the *_arg() funtions that take a default value (to be used when the argument isn't available). It could look something like this (where '0' is the default value for arg 4 and -1 is the default value for arg 5): argstr = sprintf("%d %d %d %d %d", int_arg(1), int_arg(2), int_arg(3), int_arg_default(4, 0), int_arg(5, -1)) -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.