From: "jistone at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/14389] sprintf not formatting "%#o" output properly
Date: Mon, 23 Jul 2012 19:52:00 -0000 [thread overview]
Message-ID: <bug-14389-6586-YYgFhBabD8@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-14389-6586@http.sourceware.org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=14389
Josh Stone <jistone at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jistone at redhat dot com
--- Comment #1 from Josh Stone <jistone at redhat dot com> 2012-07-23 19:52:31 UTC ---
(In reply to comment #0)
> The "%#o" formatting string isn't handling the value of 0 properly. '0' should
> be formatted as '0', not '00'.
[...]
> (This is causing a failure in the nd_syscall.exp testcase for umask, because
> the nd_syscall probe uses the 'returnstr' function, which uses the kernel's
> snprintf() function which correctly handles 0.)
Seems like just a difference of opinion to me. We also print %#x,0 as 0x0,
which I know differs from glibc, but I'm not sure what the kernel does with
that.
We could just as well flip this that returnstr() ought to be using stap's own
formatting functions for consistency...
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
prev parent reply other threads:[~2012-07-23 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 19:34 [Bug runtime/14389] New: " dsmith at redhat dot com
2012-07-23 19:52 ` jistone at redhat dot com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-14389-6586-YYgFhBabD8@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).