From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7341 invoked by alias); 3 Oct 2012 21:22:15 -0000 Received: (qmail 7251 invoked by uid 48); 3 Oct 2012 21:22:01 -0000 From: "dsmith at redhat dot com" To: systemtap@sourceware.org Subject: [Bug releng/14655] kallsyms_lookup_name is not exported by kernel versions prior to 2.6.33 Date: Wed, 03 Oct 2012 21:22:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: releng X-Bugzilla-Keywords: X-Bugzilla-Severity: minor X-Bugzilla-Who: dsmith at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2012-q4/txt/msg00016.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=14655 David Smith changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dsmith at redhat dot com --- Comment #2 from David Smith 2012-10-03 21:22:00 UTC --- I've taken a look at your patch. I know this is a first draft, but it misses use of kallsyms_lookup_name() in runtime/stp_task_work.c and runtime/transport/transport.c. In general, kernel version checks don't work well. Systemtap tries to work with so many kernels, which may or may not have a feature enabled, backported, etc. to it. Here's a possible different approach. Instead of a kernel version check, do an output_exportconf() test to see if kallsyms_lookup_name is exported (in buildrun.cxx). If not, define STAPCONF_KALLSYMS_LOOKUP_NAME_UNEXPORTED (or some better name). If that is defined, define a dummy kallsyms_lookup_name() function in the runtime that either warns or errors and always returns NULL. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.