From: "tschan+sourceware at devzone dot ch" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug uprobes/14774] process.statement("*@file:*") probes don't match all functions
Date: Sat, 27 Oct 2012 16:11:00 -0000 [thread overview]
Message-ID: <bug-14774-6586-aBmQ7oTPQo@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-14774-6586@http.sourceware.org/bugzilla/>
http://sourceware.org/bugzilla/show_bug.cgi?id=14774
--- Comment #1 from Daniel Tschan <tschan+sourceware at devzone dot ch> 2012-10-27 16:10:51 UTC ---
Created attachment 6704
--> http://sourceware.org/bugzilla/attachment.cgi?id=6704
Proposed bug fix
Tracked down the bug to the method iterate_over_srcfile_lines in dwflpp.cxx by
using systemtap on itself:
if (line_type == RELATIVE)
{
// body omitted
}
else if (line_type == WILDCARD)
function_line (&lineno);
else if (line_type == RANGE) { /* correct lineno */
// body ommited
}
for (int l = lineno; ; l = l + 1)
{
// body ommited
}
If both function name and line number are wildcards the above code matches a
"random" function in the source file an sets lineno to its start. The following
code then only looks a this matched function an all functions defined later in
the source file.
The attached patch seems to fix this problem.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
next prev parent reply other threads:[~2012-10-27 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 15:14 [Bug uprobes/14774] New: " tschan+sourceware at devzone dot ch
2012-10-27 16:11 ` tschan+sourceware at devzone dot ch [this message]
2012-10-27 16:22 ` [Bug translator/14774] " fche at redhat dot com
2012-10-27 22:38 ` tschan+sourceware at devzone dot ch
2012-10-27 23:38 ` fche at redhat dot com
2012-10-29 20:01 ` fche at redhat dot com
2012-10-30 11:52 ` tschan+sourceware at devzone dot ch
2012-10-30 15:08 ` fche at redhat dot com
2012-11-03 19:19 ` tschan+sourceware at devzone dot ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-14774-6586-aBmQ7oTPQo@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).