From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46851 invoked by alias); 10 Nov 2016 15:32:58 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 46497 invoked by uid 48); 10 Nov 2016 15:32:45 -0000 From: "mcermak at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/14924] warn on complex $ptr->foo expressions in .return probes Date: Thu, 10 Nov 2016 15:32:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mcermak at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2016-q4/txt/msg00061.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D14924 --- Comment #6 from Martin Cermak --- Created attachment 9619 --> https://sourceware.org/bugzilla/attachment.cgi?id=3D9619&action=3Dedit possible patch (In reply to Frank Ch. Eigler from comment #4) > Created attachment 9616 [details] > possible patch >=20 > A more blunt but not crazy approach, which warns on any >=20 > probe FOO.return { $var } >=20 So the above would warn whenever the autosaving feature gets used. What if= the warning message would only pop up in case a dereference is involved within = the expression in question? Like in $foo->bar->baz per Comment#0 ? The attach= ed patch does that. But of course, it's simply extendable to apply to any tar= get $var in a .return probe. Also an "info" output/log level might be introduced as an analogy to "warni= ng" [session.print_warning()] with an option to turn it off, or make it a regul= ar warning? Or maybe better yet, it might be turned off by default with an op= tion to turn it on on demand - like additional hints if the user wants it. Just thoughts. Too verbose. Sorry :) --=20 You are receiving this mail because: You are the assignee for the bug.