From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38808 invoked by alias); 17 Oct 2016 17:24:12 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 38517 invoked by uid 48); 17 Oct 2016 17:23:56 -0000 From: "jistone at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/14924] warn on complex $ptr->foo expressions in .return probes Date: Mon, 17 Oct 2016 17:24:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jistone at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2016-q4/txt/msg00027.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D14924 Josh Stone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jistone at redhat dot com --- Comment #2 from Josh Stone --- If we make it a warning, then anyone who wants to be strict (stap -W) will = have to use @entry($foo->bar) whenever that entry-time snapshotting is really wh= at they want. I think that will be annoying to those who are used to the curr= ent behavior. Perhaps this needs something softer than a warning, like a note. FWIW, autocast should make ($foo)->bar possible, for a nicer workaround than the suggestion involving explicit @cast. Since this breaks up the expressi= on, only the part inside the parentheses will be entry-saved. Or perhaps that's even more confusing, that $foo->bar and ($foo)->bar have different behavior= .=20 Plus, it doesn't yet work for @entry($foo)->bar -- see PR18579. --=20 You are receiving this mail because: You are the assignee for the bug.