[Bug tapsets/15219] syscall.exp failures on RHEL5, RHEL6, and rawhide

["dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=15219

--- Comment #10 from David Smith <dsmith at redhat dot com> ---
Created attachment 7226
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7226&action=edit
different anti-nested syscall patch

Here's a patch that attempts to fix this problem by avoiding nested syscalls.
It does this by looking at the syscall number. If we're in
syscall.clock_settime, but the syscall number isn't __NR_clock_settime, return.
This is done with macros stored in tapset/linux/syscalls.stpm, called
'__syscall_enter' and '__syscall_enter2'.

With this patch, the syscall test case passes completely on rawhide x86_64
(3.12.0-0.rc2.git0.1.fc21.x86_64).

Note that the patch isn't complete. The nd_syscall tapset files would need to
modified in a similar manner. Also, all nested syscalls weren't avoided, just
the ones needed for syscall.exp to pass.

Also note that the macros could use better names, especially since they also
get called in .return probes.

Comments welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.