public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/15219] syscall.exp failures on RHEL5, RHEL6, and rawhide
Date: Mon, 17 Jun 2013 16:10:00 -0000	[thread overview]
Message-ID: <bug-15219-6586-RzgXIngkSt@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-15219-6586@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=15219

--- Comment #8 from David Smith <dsmith at redhat dot com> ---
(In reply to David Smith from comment #7)
> - Whether we need that line or not can change with kernels. For example, the
> syscall.rt_sigprocmask probe should be skipped on RHEL[56] kernels, but not
> on rawhide.

I couldn't figure out why this change didn't work for rawhide, so I dug in a
bit more. Here's what I found. Over in
arch/x86/include/generated/asm/syscalls_32.h (which gets generated during the
kernel build), you'll see this:

====
__SYSCALL_I386(173, sys_rt_sigreturn, stub32_rt_sigreturn)
__SYSCALL_I386(174, sys_rt_sigaction, compat_sys_rt_sigaction)
__SYSCALL_I386(175, sys_rt_sigprocmask, sys_rt_sigprocmask)
__SYSCALL_I386(176, sys_rt_sigpending, compat_sys_rt_sigpending)
__SYSCALL_I386(177, sys_rt_sigtimedwait, compat_sys_rt_sigtimedwait)
__SYSCALL_I386(178, sys_rt_sigqueueinfo, compat_sys_rt_sigqueueinfo)
__SYSCALL_I386(179, sys_rt_sigsuspend, sys_rt_sigsuspend)
====

Notice that for syscall 175, rt_sigprocmask doesn't call
'compat_sys_rt_sigprocmask', it just calls the real 64-bit 'sys_rt_sigprocmask'
(see the 3rd argument and compare to rt_sigaction or rt_sigpending).

On RHEL[56], the compat function for rt_sigprocmask does get called.

(Also note that 'rt_sigreturn' calls 'stub32_rt_sigreturn', which the syscall
tapset isn't expecting. So, we probably don't handle a 32-bit rt_sigreturn
properly.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2013-06-17 16:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 17:54 [Bug tapsets/15219] New: " dsmith at redhat dot com
2013-03-04 17:54 ` [Bug tapsets/15219] " dsmith at redhat dot com
2013-03-04 18:40 ` fche at redhat dot com
2013-06-03 13:38 ` dsmith at redhat dot com
2013-06-04 15:14 ` fche at redhat dot com
2013-06-05 17:58 ` dsmith at redhat dot com
2013-06-06 18:03 ` dsmith at redhat dot com
2013-06-11 14:37 ` dsmith at redhat dot com
2013-06-17 16:10 ` dsmith at redhat dot com [this message]
2013-08-26 20:44 ` dsmith at redhat dot com
2013-10-08 18:03 ` dsmith at redhat dot com
2013-10-08 18:15 ` dsmith at redhat dot com
2013-10-31 17:24 ` dsmith at redhat dot com
2014-01-07 22:02 ` dsmith at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-15219-6586-RzgXIngkSt@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).