From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20453 invoked by alias); 17 Jun 2013 16:10:50 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 20390 invoked by uid 48); 17 Jun 2013 16:10:45 -0000 From: "dsmith at redhat dot com" To: systemtap@sourceware.org Subject: [Bug tapsets/15219] syscall.exp failures on RHEL5, RHEL6, and rawhide Date: Mon, 17 Jun 2013 16:10:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: tapsets X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dsmith at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-q2/txt/msg00296.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=15219 --- Comment #8 from David Smith --- (In reply to David Smith from comment #7) > - Whether we need that line or not can change with kernels. For example, the > syscall.rt_sigprocmask probe should be skipped on RHEL[56] kernels, but not > on rawhide. I couldn't figure out why this change didn't work for rawhide, so I dug in a bit more. Here's what I found. Over in arch/x86/include/generated/asm/syscalls_32.h (which gets generated during the kernel build), you'll see this: ==== __SYSCALL_I386(173, sys_rt_sigreturn, stub32_rt_sigreturn) __SYSCALL_I386(174, sys_rt_sigaction, compat_sys_rt_sigaction) __SYSCALL_I386(175, sys_rt_sigprocmask, sys_rt_sigprocmask) __SYSCALL_I386(176, sys_rt_sigpending, compat_sys_rt_sigpending) __SYSCALL_I386(177, sys_rt_sigtimedwait, compat_sys_rt_sigtimedwait) __SYSCALL_I386(178, sys_rt_sigqueueinfo, compat_sys_rt_sigqueueinfo) __SYSCALL_I386(179, sys_rt_sigsuspend, sys_rt_sigsuspend) ==== Notice that for syscall 175, rt_sigprocmask doesn't call 'compat_sys_rt_sigprocmask', it just calls the real 64-bit 'sys_rt_sigprocmask' (see the 3rd argument and compare to rt_sigaction or rt_sigpending). On RHEL[56], the compat function for rt_sigprocmask does get called. (Also note that 'rt_sigreturn' calls 'stub32_rt_sigreturn', which the syscall tapset isn't expecting. So, we probably don't handle a 32-bit rt_sigreturn properly.) -- You are receiving this mail because: You are the assignee for the bug.