From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10401 invoked by alias); 23 Apr 2013 14:56:45 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 10357 invoked by uid 48); 23 Apr 2013 14:56:40 -0000 From: "dsmith at redhat dot com" To: systemtap@sourceware.org Subject: [Bug tapsets/15390] Add /proc/meminfo data to memory.stp tapset Date: Tue, 23 Apr 2013 14:56:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: tapsets X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: dsmith at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-SW-Source: 2013-q2/txt/msg00058.txt.bz2 http://sourceware.org/bugzilla/show_bug.cgi?id=15390 David Smith changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dsmith at redhat dot com --- Comment #1 from David Smith 2013-04-23 14:56:39 UTC --- This is an interesting idea, that seems doable. You are right, the kernel internal interface has changed somewhat over time (from looking at 2.6.9 source vs. current source). For the example you included, I wonder if it wouldn't be better to go ahead and call si_meminfo(), which would insulate us from kernel changes a bit. Which of the /proc/meminfo values would you consider most helpful for stap to provide? Another thought I had here was we could to name the stap functions after the associated /proc/meminfo output, i.e. meminfo_memtotal(), meminfo_memfree(), meminfo_buffers(), etc. -- Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.