From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16614 invoked by alias); 21 Dec 2013 16:13:46 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 16585 invoked by uid 48); 21 Dec 2013 16:13:42 -0000 From: "mjw at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/16358] build-id difficulties with hand-built kernels Date: Sat, 21 Dec 2013 16:13:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: mjw at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2013-q4/txt/msg00477.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=16358 --- Comment #2 from Mark Wielaard --- Pushed: commit 641a4f62f1f1940540f1202c1e1aa5ce8c508234 Author: Mark Wielaard Date: Sat Dec 21 00:04:21 2013 +0100 libdwfl: Correct nested asprintf result check in report_kernel_archive. Because of wrongly placed parens the result of only one asprintf call was checked correctly. Causing dwfl_linux_kernel_report_offline to return ENOMEM. Rewrite nested if unlikely check into separate if statements to make clear what is actually being checked and what the actual unlikely condition is. Reported against systemtap "build-id difficulties with hand-built kernels" https://sourceware.org/bugzilla/show_bug.cgi?id=16358 Reported-by: Crestez Dan Leonard Signed-off-by: Mark Wielaard https://git.fedorahosted.org/cgit/elfutils.git/commit/?id=641a4f62f1f1940540f1202c1e1aa5ce8c508234 -- You are receiving this mail because: You are the assignee for the bug.