public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "fahadaliarshad at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug tapsets/16472] long chain of nested function calls consumes a lot of empty whitespace due to thread_indent() function
Date: Wed, 26 Feb 2014 14:41:00 -0000	[thread overview]
Message-ID: <bug-16472-6586-xDrenGpMeU@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-16472-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=16472

fahadaliarshad at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7365|0                           |1
        is obsolete|                            |

--- Comment #7 from fahadaliarshad at gmail dot com ---
Created attachment 7439
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7439&action=edit
patch (ver 2) for adding call-depth functionality

Based on your comment #3, I have factored out _generic_indent_depth:long (idx,
delta) and based my thread_indent_depth:long (delta:long) on it, which returns
a number now. Also, I tested the post-increment/pre-decrement behavior to keep
+1/-1 pairs (call/return) consistent.

Below is a sample output from one of my applications. Note that column two
represent the function call-depth. The field next to calls/returns(=>/<=) is
the called/returned-from function-name.

1393423651768235 0 => import
1393423651768554 1 => main
1393423651768567 1 <= main
1393423651768579 0 <= import
1393423651768594 0 => loadClass
1393423651768602 1 => findFile
1393423651768612 1 <= findFile
1393423651770492 1 => main
1393423651770509 1 <= main
1393423651770517 0 <= loadClass
1393423651770528 0 => getApplication
1393423651770544 1 => loadClass
1393423651770551 2 => findFile
1393423651770562 2 <= findFile

Please do let me know if this is fine for merging or is there anything else you
suggest to add. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2014-02-26 14:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 20:31 [Bug tapsets/16472] New: " fahadaliarshad at gmail dot com
2014-02-18 14:19 ` [Bug tapsets/16472] " fahadaliarshad at gmail dot com
2014-02-18 18:13 ` jistone at redhat dot com
2014-02-19 18:52 ` jistone at redhat dot com
2014-02-19 19:29 ` fahadaliarshad at gmail dot com
2014-02-20  0:11 ` jistone at redhat dot com
2014-02-21 14:35 ` fahadaliarshad at gmail dot com
2014-02-26 14:41 ` fahadaliarshad at gmail dot com [this message]
2014-02-26 23:06 ` jistone at redhat dot com
2014-02-27  2:52 ` fahadaliarshad at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-16472-6586-xDrenGpMeU@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).