From: "jlebon at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug testsuite/16473] rlimit.exp: adjust for weak symbols
Date: Tue, 04 Mar 2014 23:30:00 -0000 [thread overview]
Message-ID: <bug-16473-6586-iJIYDNgOfz@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-16473-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=16473
--- Comment #4 from Jonathan Lebon <jlebon at redhat dot com> ---
Created attachment 7455
--> https://sourceware.org/bugzilla/attachment.cgi?id=7455&action=edit
rlimit.patch
Looking more closely into this, I think I have a better idea of what's going
on. During partial inlining, non-inlined bits are left in e.g. foo.part.0().
This function has no DWARF info associated with it (GCC PR44712 discusses
implementing this, but it doesn't seem like there's anything in yet). It does
however show up in the symtab.
Since assess_dbinfo_reqt() only sees a function_str, it deems that the symtab
should be investigated as well. So when we tell stap to list all the functions
matching e.g. "*ar*", we pick up both DWARF functions as well as symtab
functions matching this.
This causes things that require DWARF such as $$vars to not get resolved, which
then causes an error thrown later on during type resolution.
So the error is correct insomuch as stap did try to do its best in finding
matching functions. It could be argued that a better error message should be
output (e.g. "need DWARF information for this").
As for rlimit.exp, all we need is a simple patch that will cause
assess_dbinfo_reqt() to require DWARF info (see attached patch).
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2014-03-04 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 22:48 [Bug testsuite/16473] New: " jlebon at redhat dot com
2014-01-21 1:30 ` [Bug testsuite/16473] " lberk at redhat dot com
2014-01-21 16:54 ` jlebon at redhat dot com
2014-01-21 17:02 ` jlebon at redhat dot com
2014-03-04 23:30 ` jlebon at redhat dot com [this message]
2014-03-04 23:48 ` jlebon at redhat dot com
2014-03-04 23:51 ` jlebon at redhat dot com
2014-03-05 0:15 ` jistone at redhat dot com
2014-03-14 20:46 ` jlebon at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-16473-6586-iJIYDNgOfz@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).