From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-21944-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 14138 invoked by alias); 20 Jan 2014 22:48:44 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 14107 invoked by uid 48); 20 Jan 2014 22:48:40 -0000
From: "jlebon at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug testsuite/16473] New: rlimit.exp: adjust for weak symbols
Date: Mon, 20 Jan 2014 22:48:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jlebon at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-16473-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-q1/txt/msg00042.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=16473

            Bug ID: 16473
           Summary: rlimit.exp: adjust for weak symbols
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: systemtap at sourceware dot org
          Reporter: jlebon at redhat dot com

Since support for weak symbols was added (commits 91bb908 and 0035051, also see
bug 10208), the rlimit.exp test fails as follow:

Running ../../systemtap/testsuite/systemtap.base/rlimit.exp ...
FAIL: rlimit unlimited
FAIL: rlimit AS increase (as root)
FAIL: rlimit AS realistic
FAIL: rlimit CPU increase (as root)
FAIL: rlimit CPU realistic
FAIL: rlimit NPROC increase (as root)
FAIL: rlimit NPROC realistic
FAIL: rlimit STACK increase (as root)
FAIL: rlimit STACK realistic
FAIL: rlimit FSIZE increase (as root)
FAIL: rlimit FSIZE realistic

The reason is that the rlimit.stp script is defined as:

probe kernel.function("*ar*").call { println($$vars) }

And this pattern now matches many weak symbols (especially those suffixed with
e.g. '.part.xx'). These weak symbols don't seem to have any variables
accessible, and we thus get errors when trying to resolve $$vars. This is the
kind of error we get:

[vm build]$ stap -e 'probe process("/lib*/libc.so.*").function("chmod") {
println($$vars) }' -p4
semantic error: unresolved target-symbol expression: identifier '$$vars' at
<input>:1:62
        source: probe process("/lib*/libc.so.*").function("chmod") {
println($$vars) }
                                                                             ^

Pass 2: analysis failed.  [man error::pass2]
[vm build]$ 

If this is an issue with weak symbols not giving access to $$vars when it
should, then bug 10208 should be re-opened, and this one closed. If this is an
issue with rlimit.stp being too enthusiastic, then we should change the pattern
to make it more restrictive.

-- 
You are receiving this mail because:
You are the assignee for the bug.