[Bug tapsets/16540] New: the scsi tapset could use the scsi tracepoints

[Bug tapsets/16540] New: the scsi tapset could use the scsi tracepoints

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16540

            Bug ID: 16540
           Summary: the scsi tapset could use the scsi tracepoints
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com

In newer kernels, scsi tracepoints have been added:

# stap -L 'kernel.trace("*scsi*")'
kernel.trace("scsi_dispatch_cmd_done") $cmd:struct scsi_cmnd*
kernel.trace("scsi_dispatch_cmd_error") $cmd:struct scsi_cmnd* $rtn:int
kernel.trace("scsi_dispatch_cmd_start") $cmd:struct scsi_cmnd*
kernel.trace("scsi_dispatch_cmd_timeout") $cmd:struct scsi_cmnd*
kernel.trace("scsi_eh_wakeup") $shost:struct Scsi_Host*

Support for these tracepoints could be added to the scsi tapset. For instance,
the 'scsi_dispatch_cmd_done' tracepoint is called as the first thing in the
scsi_done() function, which means the scsi.iodone probe alias could be written
to prefer the tracepoint to a function probe.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/16540] the scsi tapset could use the scsi tracepoints

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16540

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
The 'scsi_dispatch_cmd_done' tracepoint was the only exact match to a probe
point. Support for that tracepoint was added to the scsi.iodone probe alias in
commit 448be91.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug tapsets/16540] the scsi tapset could use the scsi tracepoints

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16540

--- Comment #2 from David Smith <dsmith at redhat dot com> ---
An additional fix for older kernels was added in commit c593027.

-- 
You are receiving this mail because:
You are the assignee for the bug.