From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21704 invoked by alias); 20 Feb 2014 20:58:48 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 21678 invoked by uid 48); 20 Feb 2014 20:58:44 -0000 From: "jistone at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/16614] signal forwarding to child processes uses invalid pthread* functions Date: Thu, 20 Feb 2014 20:58:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jistone at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-q1/txt/msg00132.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=16614 Josh Stone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jistone at redhat dot com --- Comment #1 from Josh Stone --- (In reply to Frank Ch. Eigler from comment #0) > We need a signal-safe structure for collecting & iterating child pids. We may just need to make spawned_pids_t properly either-or, signal-safe or thread-safe but not both. At the moment, stap is single-threaded and calls kill_stap_spawn from a signal handler; stap-serverd is multithreaded but only kills via main. So stap only needs the signal-masking, and stap-serverd only needs the pthread mutex. (In fact, the use of sigprocmask is unspecified in multithreaded processes.) This is half-way selected by the SINGLE_THREADED macro now, but that's a big hammer, not even set by stap. -- You are receiving this mail because: You are the assignee for the bug.