From: "jlebon at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/16615] New: don't require access to dwarf_query in has_single_line_record()
Date: Thu, 20 Feb 2014 20:55:00 -0000 [thread overview]
Message-ID: <bug-16615-6586@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=16615
Bug ID: 16615
Summary: don't require access to dwarf_query in
has_single_line_record()
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: translator
Assignee: systemtap at sourceware dot org
Reporter: jlebon at redhat dot com
The function iterate_over_srcfile_lines() iterates over target lines specified
by the user. When a line corresponds to multiple addresses,
iterate_over_srcfile_lines() looks around the area to see if there is another
line that we could suggest to users that has a single line record, which is why
has_single_line_record() is used.
The issue is that has_single_line_record() requires access to
q->filtered_functions and q->filtered_inlines to ensure that the suggested
lines fall within functions the user targeted.
There are various FIXMEs and XXXs in these parts of the code related to
eventually getting rid of this coupling.
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2014-02-20 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 20:55 jlebon at redhat dot com [this message]
2014-02-20 20:57 ` [Bug translator/16615] " jlebon at redhat dot com
2014-04-08 14:29 ` jlebon at redhat dot com
2014-04-17 18:22 ` jlebon at redhat dot com
2014-04-17 21:56 ` jlebon at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-16615-6586@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).