From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-22032-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 15321 invoked by alias); 20 Feb 2014 20:55:38 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 15285 invoked by uid 48); 20 Feb 2014 20:55:34 -0000
From: "jlebon at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/16615] New: don't require access to dwarf_query in has_single_line_record()
Date: Thu, 20 Feb 2014 20:55:00 -0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: translator
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jlebon at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-16615-6586@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-q1/txt/msg00130.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=16615

            Bug ID: 16615
           Summary: don't require access to dwarf_query in
                    has_single_line_record()
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: jlebon at redhat dot com

The function iterate_over_srcfile_lines() iterates over target lines specified
by the user. When a line corresponds to multiple addresses,
iterate_over_srcfile_lines() looks around the area to see if there is another
line that we could suggest to users that has a single line record, which is why
has_single_line_record() is used.

The issue is that has_single_line_record() requires access to
q->filtered_functions and q->filtered_inlines to ensure that the suggested
lines fall within functions the user targeted.

There are various FIXMEs and XXXs in these parts of the code related to
eventually getting rid of this coupling.

-- 
You are receiving this mail because:
You are the assignee for the bug.