[Bug translator/16829] New: Trigger STAPBM_VERBOSE=true automatically when -v's are specified with java probes

[Bug translator/16829] New: Trigger STAPBM_VERBOSE=true automatically when -v's are specified with java probes

[lberk at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16829

            Bug ID: 16829
           Summary: Trigger STAPBM_VERBOSE=true automatically when -v's
                    are specified with java probes
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: lberk at redhat dot com

The stapbm script (handling stap/byteman interaction and setup) has a verbosity
trigger of 'STAPBM_VERBOSE!=no'.  Currently the only way to trigger it, is to
manually set the environment variable when running a script, leaving users that
don't know about it with very little information when java probes aren't
inserted.  This could be avoided if, when enough -v's are triggered (say 2+),
we automatically set and passed the 'STAPBM_VERBOSE=geronimo' variable to
stapbm.  This is particularly useful in cases where stap has been built from
git and a commonly missed step is linking the appropriate helper .jar and .so

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/16829] Trigger STAPBM_VERBOSE=true automatically when -v's are specified with java probes

[lberk at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16829

Lukas Berk <lberk at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Lukas Berk <lberk at redhat dot com> ---
Fixed in:

commit cc8a995fdf66d4f3ea734de51447921d06eadd6f
Author: Lukas Berk <lberk@redhat.com>
Date:   Wed Apr 16 09:45:20 2014 -0400

PR16829 - trigger STAPBM_VERBOSE=true with two or more -v flags

*tapset-method.cxx - pass STAPBM_VERBOSE=true automatically when -vv or
                     higher is specified to make debugging setup issues
                     easier

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/16829] Trigger STAPBM_VERBOSE=true automatically when -v's are specified with java probes

[lberk at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16829

--- Comment #2 from Lukas Berk <lberk at redhat dot com> ---
Reworked the solution based on feedback from Josh and Frank, instead of setting
the environment variable in the generated code, have it set as an general
environment variable during runtime.

Commit c31d198c201b866efe7b1c5ff6504506e9db23a1
PR16829 rework, have staprun export verbosity flag

*java/stapbm.in - rename STAPBM_VERBOSE to general SYSTEMTAP_VERBOSE
flag
*staprun/staprun.8 - note new SYSTEMTAP_VERBOSE env variable
*staprun/staprun.c - set SYSTEMTAP_VERBOSE env var from -v's passed to
   staprun
*tapset-method.cxx - revert leftbits string to previous assignment

-- 
You are receiving this mail because:
You are the assignee for the bug.