[Bug translator/16955] New: blacklisting requires better feedback

[Bug translator/16955] New: blacklisting requires better feedback

[jlebon at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16955

            Bug ID: 16955
           Summary: blacklisting requires better feedback
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: jlebon at redhat dot com

When a function is omitted because it is blacklisted, there is no useful
feedback:

$ stap -e 'probe kernel.function("do_symlink") { next }'
semantic error: while resolving probe point: identifier 'kernel' at :1:7
        source: probe kernel.function("do_symlink") { next }
                      ^

semantic error: no match (similar functions: do_symlink, add_symlink,
del_symlink, do_setlink, SyS_symlink)
Pass 2: analysis failed.  [man error::pass2]
$

It's especially confusing because do_symlink is listed in the list of
alternatives. We should provide some indication as to why there was no match.

There is already some output hidden behind -vv to show that it is blacklisted:

...
probe do_symlink@init/initramfs.c:364 kernel reloc=.dynamic
pc=0xffffffff81d2116e init/exit - skipped
...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/16955] blacklisting requires better feedback

[jlebon at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16955

--- Comment #1 from Jonathan Lebon <jlebon at redhat dot com> ---
Created attachment 7606
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7606&action=edit
blacklist patch

Proposed patch to add a warning if blacklisted. Effect:

$ stap -e 'probe kernel.function("do_symlink") { next }'
WARNING: function do_symlink is in blacklisted section: keyword at <input>:1:1
 source: probe kernel.function("do_symlink") { next }
         ^
semantic error: while resolving probe point: identifier 'kernel' at :1:7
        source: probe kernel.function("do_symlink") { next }
                      ^

semantic error: no match (similar functions: do_symlink, add_symlink,
del_symlink, do_setlink, SyS_symlink)
Pass 2: analysis failed.  [man error::pass2]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug translator/16955] blacklisting requires better feedback

[jlebon at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16955

Jonathan Lebon <jlebon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Jonathan Lebon <jlebon at redhat dot com> ---
Merged in master, commit 2f18e69.

-- 
You are receiving this mail because:
You are the assignee for the bug.