public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [Bug testsuite/17155] New: systemtap.examples/profiling/functioncallcount.stp failures on x86_64
@ 2014-07-14 13:54 dsmith at redhat dot com
  2014-07-14 15:02 ` [Bug testsuite/17155] " dsmith at redhat dot com
  0 siblings, 1 reply; 2+ messages in thread
From: dsmith at redhat dot com @ 2014-07-14 13:54 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=17155

            Bug ID: 17155
           Summary: systemtap.examples/profiling/functioncallcount.stp
                    failures on x86_64
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testsuite
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com

When I run the systemtap.examples/check.exp testcase (which tests all the
examples), the functioncallcount.stp example fails about half the time on
x86_64. When it fails, I see this in systemtap.log:

====
ERROR: probe overhead exceeded threshold
WARNING: Number of errors: 1, skipped probes: 0
WARNING: /usr/local/bin/staprun exited with status: 1
Pass 5: run failed.  [man error::pass5]
child process exited abnormally
RC 1
FAIL: systemtap.examples/profiling/functioncallcount run
====

The guts of functioncallcount.stp look like:

====
probe kernel.function(@1).call {  # probe functions listed on commandline
  called[probefunc()] <<< 1  # add a count efficiently
}

global called

probe end {
  foreach (fn in called-)  # Sort by call count (in decreasing order)
  #       (fn+ in called)  # Sort by function name
    printf("%s %d\n", fn, @count(called[fn]))
  exit()
}
====

Because of bug #13693, probefunc() was rewritten and now has a higher overhead.
If we switch to ppfunc(), this example script should work more often.

(The use of the new probefunc() may also be contributing to bug #17140)

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug testsuite/17155] systemtap.examples/profiling/functioncallcount.stp failures on x86_64
  2014-07-14 13:54 [Bug testsuite/17155] New: systemtap.examples/profiling/functioncallcount.stp failures on x86_64 dsmith at redhat dot com
@ 2014-07-14 15:02 ` dsmith at redhat dot com
  0 siblings, 0 replies; 2+ messages in thread
From: dsmith at redhat dot com @ 2014-07-14 15:02 UTC (permalink / raw)
  To: systemtap

https://sourceware.org/bugzilla/show_bug.cgi?id=17155

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Fixed in commit 69ee8ac. Changed all the examples to use ppfunc() instead of
probefunc().

-- 
You are receiving this mail because:
You are the assignee for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-14 15:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-14 13:54 [Bug testsuite/17155] New: systemtap.examples/profiling/functioncallcount.stp failures on x86_64 dsmith at redhat dot com
2014-07-14 15:02 ` [Bug testsuite/17155] " dsmith at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).