[Bug translator/17231] New: sysroot is too often prepended

["jistone at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17231

            Bug ID: 17231
           Summary: sysroot is too often prepended
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
          Assignee: systemtap at sourceware dot org
          Reporter: jistone at redhat dot com

# normal:
$ stap -l 'process("/bin/ls").function("main")' 
process("/usr/bin/ls").function("main")

# symroot identity:
$ ./stap -l 'process("/bin/ls").function("main")' --sysroot / 
process("/usr/bin/ls").function("main")

# add a trivial real symroot
$ sudo mount --bind / /mnt
$ ls -l /mnt/bin/ls
-rwxr-xr-x. 1 root root 121K Mar  5 05:09 /mnt/bin/ls
$ stap -l 'process("/bin/ls").function("main")' --sysroot /mnt --vp 02
semantic error: while resolving probe point: identifier 'process' at
<input>:1:7
   thrown from: ../elaborate.cxx:1061
        source: probe process("/bin/ls").function("main") {}
                      ^

semantic error: cannot find executable '/mnt//mnt//bin/ls'
   thrown from: ../tapsets.cxx:672


The sysroot is first prepended in dwarf_builder::build(), then again when
base_query::base_query() calls find_executable(), and then it fails when
is_fully_resolved() compares the path to yet another find_executable().  By
that time we have twice-prepended compared to thrice, which of course is not
equal.


It also fails when the filename has no path to start with, which ought to
search $PATH in the sysroot:

$ stap -l 'process("ls").function("main")' 
process("/usr/bin/ls").function("main")

$ stap -l 'process("ls").function("main")' --sysroot /mnt --vp 02
semantic error: while resolving probe point: identifier 'process' at
<input>:1:7
   thrown from: ../elaborate.cxx:1061
        source: probe process("ls").function("main") {}
                      ^

semantic error: cannot find executable '/mnt//mnt/ls'
   thrown from: ../tapsets.cxx:672

or even:
$ stap -l 'process("ls").function("main")' --sysroot / --vp 02
semantic error: while resolving probe point: identifier 'process' at
<input>:1:7
   thrown from: ../elaborate.cxx:1061
        source: probe process("ls").function("main") {}
                      ^

semantic error: cannot find executable '//ls'
   thrown from: ../tapsets.cxx:672

-- 
You are receiving this mail because:
You are the assignee for the bug.