[Bug runtime/17706] New: user string copy fault on s390 in 31-on-64 mode

[Bug runtime/17706] New: user string copy fault on s390 in 31-on-64 mode

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17706

            Bug ID: 17706
           Summary: user string copy fault on s390 in 31-on-64 mode
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: mcermak at redhat dot com

I see following user string copy fault on s390 in 31-on-64 mode. Note that
strace seems to have similar issue:

 7.1 S s390x # cat openclose.c 
/* COVERAGE: open openat close creat */
#define _GNU_SOURCE
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <stdlib.h>
#include <unistd.h>


int main()
{
  int fd1;

  fd1 = openat(AT_FDCWD, "foobar2", O_WRONLY|O_CREAT, S_IRWXU);

  close(fd1);

  return 0;
}
 7.1 S s390x # gcc openclose.c -m31
 7.1 S s390x # stap -e 'probe syscall.openat {print(user_string($filename))}'
-c ./a.out 
ERROR: user string copy fault -14 at 000002aa004006a0 [man error::fault] near
identifier 'user_string_n' at
/root/mcermak-systemtap/systemtap-build/share/systemtap/tapset/uconversions.stp:120:10
WARNING: Number of errors: 1, skipped probes: 1
WARNING: /root/mcermak-systemtap/systemtap-build/bin/staprun exited with
status: 1
Pass 5: run failed.  [man error::pass5]
 7.1 S s390x #


Please, review.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/17706] user string copy fault on s390 in 31-on-64 mode

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17706

--- Comment #1 from Martin Cermak <mcermak at redhat dot com> ---
Casting $filename to uint32 in the tapset fixes the issue. This is for the
compat mode:

filename = user_string_quoted(__uint32($filename))

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/17706] user string copy fault on s390 in 31-on-64 mode

[mcermak at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17706

Martin Cermak <mcermak at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|systemtap at sourceware dot org    |mcermak at redhat dot com

-- 
You are receiving this mail because:
You are the assignee for the bug.