From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31970 invoked by alias); 5 Feb 2015 23:05:25 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 31915 invoked by uid 48); 5 Feb 2015 23:05:21 -0000 From: "jlebon at redhat dot com" To: systemtap@sourceware.org Subject: [Bug translator/17906] The test to restrict nearest probes to ABSOLUTE and RELATIVE causing unprivileged_probes.exp tests with wildcards to fail Date: Thu, 05 Feb 2015 23:05:00 -0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: systemtap X-Bugzilla-Component: translator X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jlebon at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: systemtap at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-q1/txt/msg00107.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=17906 Jonathan Lebon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jlebon at redhat dot com --- Comment #1 from Jonathan Lebon --- Hey Will, Thanks for reporting this, looks like I didn't catch it when I made the change. If I remember correctly, the reasoning was that it didn't make sense to have wildcards with .nearest. E.g. .statement("foo@file.c:15").nearest and .statement("foo@file.c+3").nearest have clear meanings (use the nearest probe-able addrs to these linenos). On the other hand, with .statement("foo@file.c:*").nearest, since "*" already means "expand to all possible probe-able linenos", adding a .nearest makes no difference since they will all already be valid linenos. In that sense, I guess we could allow the syntax without really changing behaviour. At the time, I leaned on the stricter interpretation of "this is redundant so the user probably meant something else". -- You are receiving this mail because: You are the assignee for the bug.