* [Bug translator/17958] New: Systemtap doesn't like variables with ~ in their name @ 2015-02-11 15:29 aram.h at mgk dot ro 2015-02-11 15:38 ` [Bug translator/17958] " aram.h at mgk dot ro ` (4 more replies) 0 siblings, 5 replies; 6+ messages in thread From: aram.h at mgk dot ro @ 2015-02-11 15:29 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=17958 Bug ID: 17958 Summary: Systemtap doesn't like variables with ~ in their name Product: systemtap Version: unspecified Status: NEW Severity: normal Priority: P2 Component: translator Assignee: systemtap at sourceware dot org Reporter: aram.h at mgk dot ro CC: mjw at redhat dot com Go generates synthetic names for unnamed return argument of the form ~rN and ~bN. The linker will take these symbols and happily generate DWARF for them using the same names, DWARF which will cause systemtap to: /tmp/stap0HUzn4/stap_781fe1254d17c543f4a055e0fd334bdc_557047_src.c:15047:38: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘~’ token static void function__dwarf_tvar_get_~r0_259 (struct context * __restrict__ c); Notice the ~ in the function name. -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug translator/17958] Systemtap doesn't like variables with ~ in their name 2015-02-11 15:29 [Bug translator/17958] New: Systemtap doesn't like variables with ~ in their name aram.h at mgk dot ro @ 2015-02-11 15:38 ` aram.h at mgk dot ro 2015-04-09 12:50 ` mjw at redhat dot com ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: aram.h at mgk dot ro @ 2015-02-11 15:38 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=17958 Aram Hăvărneanu <aram.h at mgk dot ro> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aram.h at mgk dot ro -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug translator/17958] Systemtap doesn't like variables with ~ in their name 2015-02-11 15:29 [Bug translator/17958] New: Systemtap doesn't like variables with ~ in their name aram.h at mgk dot ro 2015-02-11 15:38 ` [Bug translator/17958] " aram.h at mgk dot ro @ 2015-04-09 12:50 ` mjw at redhat dot com 2015-04-09 16:30 ` mjw at redhat dot com ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: mjw at redhat dot com @ 2015-04-09 12:50 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=17958 --- Comment #1 from Mark Wielaard <mjw at redhat dot com> --- I can see how this would fail and the fix is probably easy, but I hae some trouble creating a reproducer. Do you have a simple stap script and golang program that triggers this? -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug translator/17958] Systemtap doesn't like variables with ~ in their name 2015-02-11 15:29 [Bug translator/17958] New: Systemtap doesn't like variables with ~ in their name aram.h at mgk dot ro 2015-02-11 15:38 ` [Bug translator/17958] " aram.h at mgk dot ro 2015-04-09 12:50 ` mjw at redhat dot com @ 2015-04-09 16:30 ` mjw at redhat dot com 2015-04-09 16:31 ` mjw at redhat dot com 2015-04-09 20:31 ` mjw at redhat dot com 4 siblings, 0 replies; 6+ messages in thread From: mjw at redhat dot com @ 2015-04-09 16:30 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=17958 --- Comment #2 from Mark Wielaard <mjw at redhat dot com> --- After fixing PR17958 and PR17959 I got a reproducer. Now basically anything using $$parms in a probe will trigger it. It probably didn't show up before those bugs were fixed because stap thought it couldn't resolve those variable locations (and so would just produce a "static" '?' value). -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug translator/17958] Systemtap doesn't like variables with ~ in their name 2015-02-11 15:29 [Bug translator/17958] New: Systemtap doesn't like variables with ~ in their name aram.h at mgk dot ro ` (2 preceding siblings ...) 2015-04-09 16:30 ` mjw at redhat dot com @ 2015-04-09 16:31 ` mjw at redhat dot com 2015-04-09 20:31 ` mjw at redhat dot com 4 siblings, 0 replies; 6+ messages in thread From: mjw at redhat dot com @ 2015-04-09 16:31 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=17958 --- Comment #3 from Mark Wielaard <mjw at redhat dot com> --- (In reply to Mark Wielaard from comment #2) > After fixing PR17958 and PR17959 Sorry, PR17957 and PR17959 -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug translator/17958] Systemtap doesn't like variables with ~ in their name 2015-02-11 15:29 [Bug translator/17958] New: Systemtap doesn't like variables with ~ in their name aram.h at mgk dot ro ` (3 preceding siblings ...) 2015-04-09 16:31 ` mjw at redhat dot com @ 2015-04-09 20:31 ` mjw at redhat dot com 4 siblings, 0 replies; 6+ messages in thread From: mjw at redhat dot com @ 2015-04-09 20:31 UTC (permalink / raw) To: systemtap https://sourceware.org/bugzilla/show_bug.cgi?id=17958 Mark Wielaard <mjw at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Mark Wielaard <mjw at redhat dot com> --- commit e207d98fdd2ccb31e9abb4956f5814022892d17e Author: Mark Wielaard <mjw@redhat.com> Date: Thu Apr 9 22:17:21 2015 +0200 PR17958 escape DWARF names that aren't C identifier strings. Some language compilers (golang) might output DWARF names that are not valid C identifier strings. Provide a escaped_indentifier_string () function to turn those into valid C identifier strings so the generated C code compiles cleanly. -- You are receiving this mail because: You are the assignee for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-09 20:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-02-11 15:29 [Bug translator/17958] New: Systemtap doesn't like variables with ~ in their name aram.h at mgk dot ro 2015-02-11 15:38 ` [Bug translator/17958] " aram.h at mgk dot ro 2015-04-09 12:50 ` mjw at redhat dot com 2015-04-09 16:30 ` mjw at redhat dot com 2015-04-09 16:31 ` mjw at redhat dot com 2015-04-09 20:31 ` mjw at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).