public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "dsmith at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug translator/18079] autocast doesn't work with @defined
Date: Fri, 27 May 2016 14:25:00 -0000	[thread overview]
Message-ID: <bug-18079-6586-gh8bfXbVHZ@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-18079-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=18079

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dsmith at redhat dot com

--- Comment #2 from David Smith <dsmith at redhat dot com> ---
Created attachment 9288
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9288&action=edit
workaround patch

Here's a patch that attempts to workaround this bug. It adds an error message
when autocast operators are used with @define. Using this error message, I used
the buildok test to check for errors in the tapset. The only problems I found
were in tapset/linux/nfs_proc.stp. Fixes for that tapset are included in the
patch.

With this patch, I then ran the entire testsuite. The only other time the new
error message was printed was in semok/autocast14.stp.

Here's what the error message looks like in use:

====
semantic error: autocast operators don't work with @defined: operator
'@defined' at /root/src/testsuite/semok/autocast14.stp:14:10
        source:     if (!@defined(task_current()->mm)) {
                         ^

Pass 2: analysis failed.  [man error::pass2]^M
====

Should this be an error or warning?

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2016-05-27 14:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 22:11 [Bug translator/18079] New: " jistone at redhat dot com
2015-03-03 22:25 ` [Bug translator/18079] " jistone at redhat dot com
2016-05-27 14:25 ` dsmith at redhat dot com [this message]
2016-05-27 17:24 ` jistone at redhat dot com
2016-06-22 15:48 ` fche at redhat dot com
2016-06-24 17:43 ` jistone at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-18079-6586-gh8bfXbVHZ@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).